gobblin icon indicating copy to clipboard operation
gobblin copied to clipboard

[GOBBLIN-812] adds worker id param to set taskrunnner id explicitly

Open jhsenjaliya opened this issue 6 years ago • 1 comments

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

  • [x] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
    • https://issues.apache.org/jira/browse/GOBBLIN-812

Description

  • [x] Here are some details about my PR, including screenshots (if applicable): GobblinTaskRunner can take and use worker id from command line if specified while starting the worker.

Tests

  • [x] My PR adds the following unit tests OR does not need testing for this extremely good reason: no functional code change

Commits

  • [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

jhsenjaliya avatar Oct 22 '19 16:10 jhsenjaliya

Codecov Report

Merging #2775 into master will increase coverage by 41.19%. The diff coverage is 15.38%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #2775       +/-   ##
=============================================
+ Coverage      4.15%   45.35%   +41.19%     
- Complexity      744     8861     +8117     
=============================================
  Files          1894     1894               
  Lines         70829    70838        +9     
  Branches       7787     7788        +1     
=============================================
+ Hits           2942    32126    +29184     
+ Misses        67574    35752    -31822     
- Partials        313     2960     +2647
Impacted Files Coverage Δ Complexity Δ
...bblin/cluster/GobblinClusterConfigurationKeys.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
.../org/apache/gobblin/cluster/GobblinTaskRunner.java 63.11% <15.38%> (+63.11%) 28 <0> (+28) :arrow_up:
...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java 63.33% <0%> (-1.12%) 15% <0%> (-1%)
...gobblin/service/monitoring/JobStatusRetriever.java 0% <0%> (ø) 2% <0%> (+2%) :arrow_up:
...ata/management/copy/hive/HivePartitionFileSet.java 0.95% <0%> (+0.95%) 1% <0%> (+1%) :arrow_up:
...ain/java/org/apache/gobblin/runtime/TaskState.java 81.97% <0%> (+1.16%) 32% <0%> (ø) :arrow_down:
...pache/gobblin/runtime/GobblinMultiTaskAttempt.java 56.3% <0%> (+1.35%) 27% <0%> (+2%) :arrow_up:
...ava/org/apache/gobblin/runtime/MultiConverter.java 83.6% <0%> (+1.63%) 9% <0%> (+1%) :arrow_up:
...rg/apache/gobblin/runtime/FsDatasetStateStore.java 73.8% <0%> (+1.78%) 35% <0%> (+1%) :arrow_up:
...a/org/apache/gobblin/cluster/SingleTaskRunner.java 1.85% <0%> (+1.85%) 1% <0%> (+1%) :arrow_up:
... and 1090 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 28d3d7b...bef44b3. Read the comment docs.

codecov-io avatar Oct 22 '19 16:10 codecov-io