gobblin
gobblin copied to clipboard
[GOBBLIN-901] add debug log while renaming the file
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
- [x] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-901
Description
- [x] Here are some details about my PR, including screenshots (if applicable): When moving the staging data to final output dir, sometime it fails due to various reasons and its hard to debug without proper info. adding some more logging would help debug the issue, specially for new user.
Tests
- [x] My PR adds the following unit tests OR does not need testing for this extremely good reason: only adding more logging
Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
- Subject is separated from body by a blank line
- Subject is limited to 50 characters
- Subject does not end with a period
- Subject uses the imperative mood ("add", not "adding")
- Body wraps at 72 characters
- Body explains "what" and "why", not "how"
Codecov Report
Merging #2754 into master will decrease coverage by
<.01%. The diff coverage is33.33%.
@@ Coverage Diff @@
## master #2754 +/- ##
============================================
- Coverage 45.27% 45.27% -0.01%
Complexity 8828 8828
============================================
Files 1889 1889
Lines 70634 70640 +6
Branches 7757 7758 +1
============================================
+ Hits 31979 31981 +2
- Misses 35701 35706 +5
+ Partials 2954 2953 -1
| Impacted Files | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| ...n/java/org/apache/gobblin/writer/FsDataWriter.java | 67.82% <33.33%> (-1.9%) |
15 <0> (ø) |
|
| ...in/java/org/apache/gobblin/cluster/HelixUtils.java | 35.51% <0%> (-3.74%) |
12% <0%> (-1%) |
|
| ...lin/restli/throttling/ZookeeperLeaderElection.java | 70% <0%> (-2.23%) |
13% <0%> (ø) |
|
| .../apache/gobblin/runtime/api/JobExecutionState.java | 80.37% <0%> (+0.93%) |
24% <0%> (ø) |
:arrow_down: |
| .../org/apache/gobblin/cluster/GobblinTaskRunner.java | 65.27% <0%> (+1.38%) |
28% <0%> (ø) |
:arrow_down: |
| ...lin/elasticsearch/writer/FutureCallbackHolder.java | 62.85% <0%> (+1.42%) |
4% <0%> (ø) |
:arrow_down: |
| ...che/gobblin/writer/HiveWritableHdfsDataWriter.java | 76.47% <0%> (+2.94%) |
9% <0%> (+1%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 5b8af8c...0d4eea2. Read the comment docs.