gobblin
gobblin copied to clipboard
[GOBBLIN-854] use typesafe config instead of java properties
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
- [x] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-854
Description
- [x] Here are some details about my PR, including screenshots (if applicable): standalone mode SchedulerDaemon uses java properties, this ticket is to use TypeSafe Config instead to make config standardized across the modes and also enable config to take benefits of TypeSafe functionalities. Also it takes 2 different config file as argument, one as default and another as custom, we probably only need one property file.
Tests
- [x] My PR adds the following unit tests OR does not need testing for this extremely good reason: not required, no change in functionality
Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
- Subject is separated from body by a blank line
- Subject is limited to 50 characters
- Subject does not end with a period
- Subject uses the imperative mood ("add", not "adding")
- Body wraps at 72 characters
- Body explains "what" and "why", not "how"
@sv2000 , can u pls review this?