gobblin
gobblin copied to clipboard
[GOBBLIN-835] Date Converter
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
- [x] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-835
Description
- [x] Here are some details about my PR, including screenshots (if applicable): New feature which enables users to convert date field present in their inputRecord of jsonElement type from one format / timezone to another format / timezone.
Tests
- [x] My PR adds the following unit tests OR does not need testing for this extremely good reason: DateConverterTest tests the conversion done in DateConverter.
Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
- Subject is separated from body by a blank line
- Subject is limited to 50 characters
- Subject does not end with a period
- Subject uses the imperative mood ("add", not "adding")
- Body wraps at 72 characters
- Body explains "what" and "why", not "how"
Codecov Report
Merging #2704 into master will increase coverage by
0.2%. The diff coverage is80.95%.
@@ Coverage Diff @@
## master #2704 +/- ##
==========================================
+ Coverage 44.9% 45.1% +0.2%
- Complexity 8713 8746 +33
==========================================
Files 1879 1880 +1
Lines 70079 70204 +125
Branches 7703 7709 +6
==========================================
+ Hits 31466 31666 +200
+ Misses 35702 35615 -87
- Partials 2911 2923 +12
| Impacted Files | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| ...g/apache/gobblin/converter/date/DateConverter.java | 80.95% <80.95%> (ø) |
5 <5> (?) |
|
| ...bblin/cluster/GobblinHelixJobLauncherListener.java | 70% <0%> (-30%) |
3% <0%> (-2%) |
|
| ...in/java/org/apache/gobblin/cluster/HelixUtils.java | 35.51% <0%> (-6.33%) |
12% <0%> (-2%) |
|
| .../gobblin/cluster/HelixRetriggeringJobCallable.java | 60.41% <0%> (-3.48%) |
9% <0%> (ø) |
|
| ...pache/gobblin/cluster/GobblinHelixJobLauncher.java | 81.53% <0%> (-1.8%) |
26% <0%> (-2%) |
|
| ...ache/gobblin/cluster/GobblinHelixJobScheduler.java | 39.21% <0%> (-1.31%) |
6% <0%> (ø) |
|
| .../org/apache/gobblin/cluster/GobblinTaskRunner.java | 64.78% <0%> (-0.94%) |
29% <0%> (ø) |
|
| ...in/service/modules/core/GobblinServiceManager.java | 54.58% <0%> (-0.46%) |
25% <0%> (ø) |
|
| ...g/apache/gobblin/writer/PartitionedDataWriter.java | 58.89% <0%> (-0.23%) |
28% <0%> (+1%) |
|
| .../org/apache/gobblin/metrics/event/TimingEvent.java | 70% <0%> (ø) |
15% <0%> (ø) |
:arrow_down: |
| ... and 16 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 8903ebf...f657a1c. Read the comment docs.