gobblin icon indicating copy to clipboard operation
gobblin copied to clipboard

[GOBBLIN-797]Refactoring ConfigStoreUtils to make it not implementation-specific

Open autumnust opened this issue 6 years ago • 1 comments

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

  • [ ] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
    • https://issues.apache.org/jira/browse/GOBBLIN-797

Description

  • [ ] Here are some details about my PR, including screenshots (if applicable): The implementation of getUriStringForTopic only works for ivy-based config-store which ConfigStoreUtils serves as a generic utility class, should not make such assumption.

Tests

  • [ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

autumnust avatar Jun 06 '19 19:06 autumnust

@jack-moseley can you take a look ? Thanks.

autumnust avatar Jun 06 '19 19:06 autumnust