gobblin
gobblin copied to clipboard
UnitTest for KafkaSource
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
- [x] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-715
Description
- [x] Here are some details about my PR, including screenshots (if applicable): We have an abstract class KafkaSource which contains a function called getWorkunits that be used in many use cases. But we have no unit test for this function. We should implement a simple subclass of KafkaSource and have a unit test to test the logic inside the function to make sure it returns the desired WorkUnits.
Tests
- [x] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
- Subject is separated from body by a blank line
- Subject is limited to 50 characters
- Subject does not end with a period
- Subject uses the imperative mood ("add", not "adding")
- Body wraps at 72 characters
- Body explains "what" and "why", not "how"
@ibuenros @htran1 @autumnust
@htran1 can you merge?
+1
Codecov Report
Merging #2582 (c94e99b) into master (f4a9966) will increase coverage by
0.04%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #2582 +/- ##
============================================
+ Coverage 47.14% 47.19% +0.04%
- Complexity 10897 10900 +3
============================================
Files 2148 2148
Lines 85045 85045
Branches 9439 9439
============================================
+ Hits 40093 40135 +42
+ Misses 41309 41269 -40
+ Partials 3643 3641 -2
see 8 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more