gobblin
gobblin copied to clipboard
[GOBBLIN-366] Adding retry into LoopingDatasetSource
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
- [x] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-366] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-366
Description
- [x] Here are some details about my PR, including screenshots (if applicable):
Tests
- [x] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
- Subject is separated from body by a blank line
- Subject is limited to 50 characters
- Subject does not end with a period
- Subject uses the imperative mood ("add", not "adding")
- Body wraps at 72 characters
- Body explains "what" and "why", not "how"
Please add Gobblin Jira for it
@ibuenros Can you review it? Thanks.
General comment: can you please avoid reformatting changes in your PRs? All the reformatting changes create a lot of visual noise and make the change harder to review.
+1