gobblin icon indicating copy to clipboard operation
gobblin copied to clipboard
verified publisher icon apache

[GOBBLIN-120] provide branch-id in converter

Open BirgerK opened this issue 8 years ago • 5 comments

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

  • [x] My PR addresses the following Gobblin JIRA issues and references them in the PR title.

Description

  • [x] Here are some details about my PR, including screenshots (if applicable): This fix allows the converter to know the branch-id of its branch.

Tests

  • [x] My PR adds the following unit tests OR does not need testing for this extremely good reason: I don't know how to test this. For testing this one needs a fork. I didn't find any good tests for Forks for taking a look.

Commits

  • [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

BirgerK avatar Dec 17 '17 19:12 BirgerK

@ibuenros Can you please review.

abti avatar Dec 18 '17 22:12 abti

btw: meanwhile the tests are green

BirgerK avatar Feb 01 '18 15:02 BirgerK

@htran1 Can you please review?

abti avatar Feb 05 '18 20:02 abti

@htran1 ^^

abti avatar Mar 23 '18 18:03 abti

ping @htran1 ^^

abti avatar May 04 '18 18:05 abti