apache
GEODE-10467: Roll develop to 2.1.0
Now that support/2.0 has been created, develop advances.
For all changes, please confirm:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Has your PR been rebased against the latest commit within the target branch (typically
develop)? - [x] Is your initial contribution a single, squashed commit?
- [ ] Does
gradlew buildrun cleanly? - [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
@JinwooHwang reviewed with AI. I can't approve so not sure it matters
Whitespace Pollution in Test Files
Location: All expected-pom.xml files (30 files modified)
Issue: The commit adds excessive trailing whitespace to every line in the expected POM files. This appears to be an XML formatting change that:
- Adds 3,248 insertions primarily consisting of whitespace
- Makes diffs harder to read
- Pollutes git history
- Has no functional benefit
Example:
Each XML element now has trailing whitespace after the closing >, making the files unnecessarily larger.
otherwise looks fine
Hi @leonfin. Thank you so much for the thorough review and catching that whitespace pollution.
You're absolutely right - the roll commit inadvertently added ~3,230 lines of trailing whitespaces throughout all the expected-pom.xml files. I've addressed this in commit 387fe5fefa:
What was fixed:
- Restored all 25 expected-pom.xml files to their clean state (before the roll)
- Removed 3,230 lines of whitespace pollution
- No functional changes to actual POM content
The files now have the proper formatting without the extraneous whitespaces. Really appreciate you taking the time to review this.
@leonfin , @sboorlagadda , @raboof and @niallkp, all checks have passed. We are ready to merge. Please let me know if you have any concerns. Thank you for your continued support.