geode icon indicating copy to clipboard operation
geode copied to clipboard

Upgrade commons-io to version 2.15.1

Open JinwooHwang opened this issue 6 months ago • 1 comments

For all changes:

  • [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • [x] Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • [ ] Is your initial contribution a single, squashed commit?

  • [x] Does gradlew build run cleanly?

  • [x] Have you written or updated unit tests to verify your changes?

  • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

JinwooHwang avatar Jun 09 '25 11:06 JinwooHwang

@niallkp: As per mailing list discussion, any chance you're able to review this?

semioticrobotic avatar Jun 17 '25 15:06 semioticrobotic

@niallkp, I would appreciate it if you could kindly provide your response at your earliest convenience. Thank you.

JinwooHwang avatar Jul 01 '25 12:07 JinwooHwang

This build failed with:

* What went wrong:
Could not determine the dependencies of task ':geode-assembly:downloadWebServers'.
> Could not resolve all task dependencies for configuration ':geode-assembly:webServerTomcat6'.
   > Could not resolve apache:tomcat:6.0.37.
     Required by:
         project :geode-assembly
      > Could not resolve apache:tomcat:6.0.37.
         > Could not get resource 'https://repo.spring.io/release/apache/tomcat/6.0.37/tomcat-6.0.37.pom'.
            > Could not GET 'https://repo.spring.io/release/apache/tomcat/6.0.37/tomcat-6.0.37.pom'. Received status code 401 from server: 
      > Could not resolve apache:tomcat:6.0.37.
         > Could not get resource 'https://archive.apache.org/dist/tomcat/tomcat-6/v6.0.37/bin/apache-tomcat-6.0.37.zip'.
            > Could not HEAD 'https://archive.apache.org/dist/tomcat/tomcat-6/v6.0.37/bin/apache-tomcat-6.0.37.zip'.
               > Connect to archive.apache.org:443 [archive.apache.org/65.108.204.189, archive.apache.org/2a01:4f9:1a:a084:0:0:0:2] failed: Network is unreachable (connect failed)

I suspect this was an intermittent failure. However, it also uncovers a problem: Tomcat 6 has long been EOL (https://tomcat.apache.org/). It would probably be good to drop unsupported Tomcat versions from Geode. I have filed https://issues.apache.org/jira/browse/GEODE-10460 for this activity. I'm not sure I can re-trigger the builds, let me close and reopen the issue and see if that helps, otherwise you'll have to amend-and-force-push to this feature branch.

raboof avatar Aug 27 '25 14:08 raboof

Thank you for looking into this and for filing GEODE-10460 @raboof. That’s a great call on dropping unsupported Tomcat versions. I agree it makes sense to clean this up rather than carry legacy dependencies forward.

I see the checks have restarted. I really appreciate your help in identifying both the intermittent failure and the broader issue.

JinwooHwang avatar Aug 27 '25 14:08 JinwooHwang

it seems this failure was already fixed in #7909, closing this in favor of that other PR.

raboof avatar Aug 27 '25 14:08 raboof