geode icon indicating copy to clipboard operation
geode copied to clipboard

Upgrade micrometer to version 1.14.0

Open JinwooHwang opened this issue 6 months ago • 1 comments

For all changes:

  • [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • [x] Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • [ ] Is your initial contribution a single, squashed commit?

  • [x] Does gradlew build run cleanly?

  • [x] Have you written or updated unit tests to verify your changes?

  • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

JinwooHwang avatar Jun 09 '25 11:06 JinwooHwang

@niallkp: As per mailing list discussion, any chance you're able to review this?

semioticrobotic avatar Jun 17 '25 15:06 semioticrobotic

@JinwooHwang-SAS Looks like there are build failures, do you think they are related to your changes?

scmbuildguy avatar Jun 24 '25 18:06 scmbuildguy

@scmbuildguy , I see -Werror in the build option which causes errors on warnings such as this deprecation message: /home/runner/work/geode/geode/geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StopServerCommand.java:17: warning: [deprecation] StringUtils in io.micrometer.core.instrument.util has been deprecated

import static io.micrometer.core.instrument.util.StringUtils.isNotBlank; ^

Task :geode-gfsh:compileJava error: warnings found and -Werror specified

JinwooHwang avatar Jun 25 '25 10:06 JinwooHwang

@niallkp and @scmbuildguy, I would appreciate it if you could kindly provide your response at your earliest convenience. Thank you.

JinwooHwang avatar Jul 01 '25 12:07 JinwooHwang

If you click the failing develop / build, you will see logs of the failure, including:

> Task :geode-gfsh:compileJava
/home/runner/work/geode/geode/geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StopServerCommand.java:17: warning: [deprecation] StringUtils in io.micrometer.core.instrument.util has been deprecated
import static io.micrometer.core.instrument.util.StringUtils.isNotBlank;
                                                ^
error: warnings found and -Werror specified
1 error
1 warning

raboof avatar Aug 27 '25 14:08 raboof

Thank you for pointing that out and for sharing the detailed logs, @raboof. I really appreciate your guidance. I’ll review the develop / build failure carefully and see what steps we can take to address it. Your insights are very helpful in moving this forward.

JinwooHwang avatar Aug 27 '25 14:08 JinwooHwang

Thank you @raboof

JinwooHwang avatar Aug 29 '25 01:08 JinwooHwang

The IntegrationTest failure seems (at least partly) related to this PR:

    elements not found:
      ["lib/HdrHistogram-2.1.12.jar", "lib/commons-io-2.11.0.jar"]
    and elements not expected:
      ["lib/HdrHistogram-2.2.2.jar",
        "lib/commons-io-2.15.1.jar",
        "lib/micrometer-commons-1.14.0.jar",
        "lib/micrometer-observation-1.14.0.jar"]
        at org.apache.geode.AssemblyContentsIntegrationTest.verifyAssemblyContents(AssemblyContentsIntegrationTest.java:67)

raboof avatar Aug 29 '25 08:08 raboof

Thank you for bringing the IntegrationTest failure to my attention, @raboof. Let me investigate the issue in detail in order to determine the appropriate fix. I truly appreciate your careful review.

JinwooHwang avatar Aug 29 '25 09:08 JinwooHwang

@JinwooHwang: Did merging this PR ultimately become unnecessary? Should this work be addressed, merged, or closed?

semioticrobotic avatar Oct 21 '25 18:10 semioticrobotic

I am so sorry @semioticrobotic. I did not have time for this project due to the migration projects. Let me work on this after the other PR get merged. Thank you.

JinwooHwang avatar Oct 21 '25 18:10 JinwooHwang