Upgrade micrometer to version 1.14.0
For all changes:
-
[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
-
[x] Has your PR been rebased against the latest commit within the target branch (typically
develop)? -
[ ] Is your initial contribution a single, squashed commit?
-
[x] Does
gradlew buildrun cleanly? -
[x] Have you written or updated unit tests to verify your changes?
-
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
@niallkp: As per mailing list discussion, any chance you're able to review this?
@JinwooHwang-SAS Looks like there are build failures, do you think they are related to your changes?
@scmbuildguy , I see -Werror in the build option which causes errors on warnings such as this deprecation message: /home/runner/work/geode/geode/geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StopServerCommand.java:17: warning: [deprecation] StringUtils in io.micrometer.core.instrument.util has been deprecated
import static io.micrometer.core.instrument.util.StringUtils.isNotBlank; ^
Task :geode-gfsh:compileJava error: warnings found and -Werror specified
@niallkp and @scmbuildguy, I would appreciate it if you could kindly provide your response at your earliest convenience. Thank you.
If you click the failing develop / build, you will see logs of the failure, including:
> Task :geode-gfsh:compileJava
/home/runner/work/geode/geode/geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StopServerCommand.java:17: warning: [deprecation] StringUtils in io.micrometer.core.instrument.util has been deprecated
import static io.micrometer.core.instrument.util.StringUtils.isNotBlank;
^
error: warnings found and -Werror specified
1 error
1 warning
Thank you for pointing that out and for sharing the detailed logs, @raboof. I really appreciate your guidance. I’ll review the develop / build failure carefully and see what steps we can take to address it. Your insights are very helpful in moving this forward.
Thank you @raboof
The IntegrationTest failure seems (at least partly) related to this PR:
elements not found:
["lib/HdrHistogram-2.1.12.jar", "lib/commons-io-2.11.0.jar"]
and elements not expected:
["lib/HdrHistogram-2.2.2.jar",
"lib/commons-io-2.15.1.jar",
"lib/micrometer-commons-1.14.0.jar",
"lib/micrometer-observation-1.14.0.jar"]
at org.apache.geode.AssemblyContentsIntegrationTest.verifyAssemblyContents(AssemblyContentsIntegrationTest.java:67)
Thank you for bringing the IntegrationTest failure to my attention, @raboof. Let me investigate the issue in detail in order to determine the appropriate fix. I truly appreciate your careful review.
@JinwooHwang: Did merging this PR ultimately become unnecessary? Should this work be addressed, merged, or closed?
I am so sorry @semioticrobotic. I did not have time for this project due to the migration projects. Let me work on this after the other PR get merged. Thank you.