geode icon indicating copy to clipboard operation
geode copied to clipboard

Upgrade to Gradle 7.4

Open ryangardner opened this issue 3 years ago • 4 comments

Upgrade to Gradle 7.4

  • Updated gradle wrapper
  • Updated usage of an internal TemporaryFileProvider to the correct location for Gradle 7
  • Update the main -> mainClass for the geode assembly to match Gradle 7 syntax
  • Move some compile scope to compileOnly (required for Gradle 7)
  • Add explicit dependsOn relationship between tasks that have dependencies that Gradle 7 complains about
  • Add a duplicatesStrategy to the processIntegrationTestResources to avoid Gradle 7 failing on a duplicate resources in shiro.ini (this duplicate seems to come from how the source set is configured)
  • Upgrade the RepeatTestExecutor to match the DefaultTestExecutor from Gradle 7.4

For all changes:

  • [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • I couldn't find one

  • [X] Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • [X] Is your initial contribution a single, squashed commit?

  • [X] Does gradlew build run cleanly?

  • I have some errors with bind exceptions for some of the tests, but those also happen on the gradle 6.8 build for me and I haven't looked deeply into them.

  • [ ] Have you written or updated unit tests to verify your changes? N/A

  • [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

ryangardner avatar Feb 09 '22 15:02 ryangardner

Sorry, I've been away from my computer this week - I saw your earlier comment about updating the commit message and I can still do that, I've just not had a chance yet.

ryangardner avatar Feb 26 '22 00:02 ryangardner

Hi Ryan, I don't know if you're subscribed [email protected], I just posted an announcement there clarifying things.

onichols-pivotal avatar Feb 26 '22 00:02 onichols-pivotal

Ah, ok. I wasn't offended by the message but the announcement clarifies the intent. Thanks.

Ryan

On Fri, Feb 25, 2022, 7:12 PM Owen Nichols @.***> wrote:

Hi Ryan, I don't know if you're subscribed @.***, I just posted an announcement https://lists.apache.org/thread/y3s11x39lwsmxjyw7y7oznlqolszyjn6 there clarifying things.

— Reply to this email directly, view it on GitHub https://github.com/apache/geode/pull/7351#issuecomment-1051387835, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABZOVLHUTGETGTIXUFR5HTU5ALHLANCNFSM5N52WGGQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

ryangardner avatar Feb 26 '22 00:02 ryangardner

Hi @ryangardner , I haven't forgotten about this. We have some internal tooling that is not ready to make the jump to Gradle 7 yet. But when it is, then this will be merged. Thanks so much for the help.

rhoughton-pivot avatar Apr 05 '22 16:04 rhoughton-pivot