fury icon indicating copy to clipboard operation
fury copied to clipboard

fix: remove commented content from git commit message

Open rajuyadav03 opened this issue 2 months ago • 6 comments

What’s Changed?

This PR removes commented lines (# and <!-- -->) from auto-generated Git commit messages, ensuring the commit history is clean and readable.

Fixes

  • Fixes #1588

Hi! I’m participating in Hacktoberfest 2025.
Please add the hacktoberfest-accepted label if appropriate. Thanks!

rajuyadav03 avatar Oct 06 '25 20:10 rajuyadav03

Hi! This PR removes commented lines from auto-generated Git commit messages — hacktoberfest-accepted label would be awesome!

rajuyadav03 avatar Oct 06 '25 20:10 rajuyadav03

Hi @rajuyadav03 , thanks for contributing to Apache Fory. To remove commented content, you may also need to update github workflow too. And invoke scripts/remove-commented-commit.sh in the github ci workflow

chaokunyang avatar Oct 07 '25 12:10 chaokunyang

Thanks — I’ve added the workflow change to invoke scripts/remove-commented-commit.sh.

rajuyadav03 avatar Oct 07 '25 17:10 rajuyadav03

Thanks — I’ve added the workflow change to invoke scripts/remove-commented-commit.sh. The workflow now gets the last commit message, runs the script, and prints the cleaned message in CI logs. Please let me know if you want the job to do anything else

rajuyadav03 avatar Oct 08 '25 20:10 rajuyadav03

@rajuyadav03 have you verified that this PR works? you can open a pull request in your forked repository, and merge it into main branch, then open another PR to see whether it works

chaokunyang avatar Oct 09 '25 15:10 chaokunyang

I verified the changes by merging them into my fork’s main and opening a PR to apache/fory. The CI checks for that PR passed: [link to PR]. Please let me know if you want any additional changes.

rajuyadav03 avatar Oct 09 '25 20:10 rajuyadav03