fury
fury copied to clipboard
apache
[Rust] Support deserialize by populate passed mut ref
Feature Request
Currently fory rust provide following deserialize API:
pub fn deserialize<T: Serializer>(&self, bf: &[u8]) -> Result<T, Error> {
let mut reader = Reader::new(bf);
let meta_offset = self.read_head(&mut reader)?;
let mut context = ReadContext::new(self, reader);
if meta_offset > 0 {
context.load_meta(meta_offset as usize);
}
<T as Serializer>::deserialize(&mut context)
}
It relies on compiler Return Value Optimization (RVO), which won't work always. And the compiler will copy small struct always.
Is your feature request related to a problem? Please describe
pub fn deserialize<T: Serializer>(&self, bf: &[u8]) -> Result<T, Error> API may introduce extra copy.
Describe the solution you'd like
Add a new API to populate passed struct directly.
pub fn deserialize_into<T: Serializer>(&self, bf: &[u8], output: &mut T) -> Result<(), Error> {
let mut reader = Reader::new(bf);
let meta_offset = self.read_head(&mut reader)?;
let mut context = ReadContext::new(self, reader);
if meta_offset > 0 {
context.load_meta(meta_offset as usize);
}
<T as Serializer>::deserialize_into(&mut context, output)
}
Describe alternatives you've considered
No response
Additional context
No response
