apache
feat: Align object array to collection serialization protocol v2
What does this PR do?
Related issues
- #1229
Does this PR introduce any user-facing change?
- [ ] Does this PR introduce any public API change?
- [ ] Does this PR introduce any binary protocol compatibility change?
Benchmark
Some CI tests are failing I am assuming its related to my implementation of the write / copy / read methods? Possibly not using try finally for push / pop generic types?
Any suggestions on running the CI suites locally so I can work on debugging the issues?
Any suggestions on running the CI suites locally so I can work on debugging the issues?
You can execute:
cd java
mvn -T10 clean install -DskipTests
cd fury-core
mvn test -Dtest=org.apache.fury.serializer.ArraySerializersTest
Or you can use IDE such jetbrains intellj to debug test one by one, I prefer this method:
So I have been running the ArraySerializerTests and they have all been passing so a bit confused on why the CICD tests are failing
@david1437 you could execute:
cd java
mvn -T10 clean install -DskipTests
cd fury-core
mvn -T16 test`
All failed tests will be printed in the end
You could download logs to look why if fail
https://github.com/apache/fury/actions/runs/14971961752/job/42054796701?pr=2218
After resolving the issues around primitives and depth increment it seems only a couple tests are failing, Would appreciate some help on those specific failing cases: JdkProxySerializerTest and NonexistentClassSerializersTest