fury icon indicating copy to clipboard operation
fury copied to clipboard

[Java] ReplaceResolveSerializer circular references copy bug

Open zhaommmmomo opened this issue 1 year ago • 1 comments

Search before asking

  • [X] I had searched in the issues and found no similar issues.

Version

fury 0.10.0-SNAPSHOT https://github.com/apache/fury/pull/1925

Component(s)

Java

Minimal reproduce step

@Test
  public void test() {
    Fury fury = Fury.builder().withRefCopy(true).withLanguage(Language.JAVA).build();
    fury.registerSerializer(Tmp.class, ReplaceResolveSerializer.class);
    Tmp a = new Tmp();
    Tmp b = new Tmp();
    a.name = "a";
    a.ref = b;
    b.name = "b";
    b.ref = a;
    Tmp copy = fury.copy(a);
    assertNotSame(copy, a);
  }

  public static class Tmp implements Serializable {
    public Object ref;
    public String name;

    private Object writeReplace() {
      return ref;
    }

    private Object readResolve() {
      return ref;
    }
  }

What did you expect to see?

The copied object should not have the same address as the original object.

What did you see instead?

The copied object has the same address as the original object. image

Anything Else?

No response

Are you willing to submit a PR?

  • [X] I'm willing to submit a PR!

zhaommmmomo avatar Nov 13 '24 14:11 zhaommmmomo

@zhaommmmomo Does this bug still persist?

chaokunyang avatar Nov 05 '25 05:11 chaokunyang