fury icon indicating copy to clipboard operation
fury copied to clipboard

feat(java): Invoke callback on read failure

Open yoohaemin opened this issue 1 year ago • 6 comments

What does this PR do?

See discussion: https://github.com/apache/fury/discussions/1848#discussion-7214836

When Fury encounters a value that does not exist in the current class definition, it can still read the value. This PR allows the user of the library to specify what to do with the value. The user can specify a function Object -> Object to update the value, and also specify a Field for that adjusted value to be set.

Related issues

https://github.com/apache/fury/discussions/1848

Does this PR introduce any user-facing change?

  • [x] Does this PR introduce any public API change?
  • [ ] Does this PR introduce any binary protocol compatibility change?

Benchmark

TODO

yoohaemin avatar Oct 06 '24 11:10 yoohaemin

Is it possible to deserialize again by taking fields that don't exist in the class and unifying them in a map property?

DemonJun avatar Oct 08 '24 01:10 DemonJun

Hi @yoohaemin , is there anything I can help to put this PR forward?

chaokunyang avatar Oct 19 '24 05:10 chaokunyang

@chaokunyang hey, thanks for the ping.

I haven't forgotten about this PR, but I am a bit swamped with other things personally and have no time to push it forward.

If you want to push it forward yourself, please feel free to do so. Otherwise, I will work on it when I have time.

Unfortunately, I can't tell you when exactly I will have time, but probably this month would be hard.

yoohaemin avatar Oct 19 '24 05:10 yoohaemin

@yoohaemin thanks for continuing working on this pr. This ia not urgent, you can take your time. I will take a look at the ci failures to see whether I can provide more inputs

chaokunyang avatar Oct 20 '24 04:10 chaokunyang

@chaokunyang Are merge commits preferred or is rebasing preferred?

yoohaemin avatar May 05 '25 08:05 yoohaemin

@chaokunyang Are merge commits preferred or is rebasing preferred?

merging is prefer when there is a conflict

chaokunyang avatar Sep 22 '25 09:09 chaokunyang