flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-38225] Sets proper precondition to ensure that GCS operations are retryable

Open JTaky opened this issue 2 months ago • 1 comments

What is the purpose of the change

Ensures that the operations become idempotent or atomic, allowing the GCS client to safely retry the 503 errors. Thus client can actually perform the retry in such conditions.

Original retry logic was added in https://github.com/apache/flink/pull/24753.

Thanks Xi Zhang for pointing to the problem and providing the solution in https://issues.apache.org/jira/browse/FLINK-38225.

Brief change log

  • Adds an option when composing the GCS request, to ensure that operation is atomic
  • Adds an option when writing to GCS, to ensure that write operation is atomic

Verifying this change

This change is already covered by existing tests, such as GSRecoverableWriterTest

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

JTaky avatar Oct 10 '25 11:10 JTaky

CI report:

  • 56f84bac0a5be0e5b8b1d49074f45b49d1bac9f1 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Oct 10 '25 11:10 flinkbot