flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-38416] bugfix correct constructor arg order

Open rymurr opened this issue 3 months ago • 3 comments

What is the purpose of the change

Fix order of arguments in constructor for NestedMapConstraint, Specifically, args for key and value getters are in the wrong order compared to when called by ConstraintEnforcerExecutor

Brief change log

  • swap keyGetters and valueGetters

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: yes
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

rymurr avatar Sep 23 '25 13:09 rymurr

Thank you for your contribution!

Could you please update your PR to match the contribution guidelines: https://flink.apache.org/how-to-contribute/code-style-and-quality-pull-requests/

In particular:

  1. Please fix the commit message to contain the Jira ticket.
  2. Please fill in the PR template

dawidwys avatar Sep 23 '25 13:09 dawidwys

CI report:

  • 0d8e7b31699b09a24817dcbd6318aef65e9b4e11 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Sep 23 '25 13:09 flinkbot

Thank you for your contribution!

Could you please update your PR to match the contribution guidelines: https://flink.apache.org/how-to-contribute/code-style-and-quality-pull-requests/

In particular:

  1. Please fix the commit message to contain the Jira ticket.
  2. Please fill in the PR template

thanks @dawidwys , done

rymurr avatar Sep 23 '25 13:09 rymurr