flink
flink copied to clipboard
[FLINK-36377] [table-planner] Add LAST_VALUE support for ROW, ARRAY, MAP, and RAW types
What is the purpose of the change
Implementing FLINK-36377 for supporting ROW, ARRAY, MAP, and RAW types for LAST_VALUE aggregate function.
Brief change log
- Modify the AggFunctionFactory to ensure that the creation of the LAST_VALUE function supports ROW, ARRAY, MAP, and RAW types.
- Modify the LastValueAggFunction and LastValueWithRetractAggFunction to support copying of complex data type arguments and remove the original handling of StringData
Verifying this change
This change added tests and can be verified as follows:
- Added test in AggregateITCase to validate ROW, MAP, ARRAY in LAST_VALUE
- Added unit test for applying LAST_VALUE for ROW in LastValueAggFunctionWithOrderTest, LastValueAggFunctionWithoutOrderTest, LastValueWithRetractAggFunctionWithOrderTest and LastValueWithRetractAggFunctionWithoutOrderTest
- Added unit test for applying LAST_VALUE for ROW and ARRAY in GroupAggregateHarnessTest
Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
@Public(Evolving): no - The serializers: no
- The runtime per-record code paths (performance sensitive): yes
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? docs
CI report:
- 54e93633423c142b6ca7b3059178e01c4a54e15b Azure: FAILURE
Bot commands
The @flinkbot bot supports the following commands:@flinkbot run azurere-run the last Azure build
@liyang1206 thank you for the contribution can you please clarify why do we need serializer changes and what do you mean by this
Implementing FLINK-36377 for supporting ROW, ARRAY, MAP, and RAW types for LAST_VALUE aggregate function.
I locally reverted all the non-test changes from this PR and all the tests continue passing... can you please clarify if there is any non-working case?