flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-37788] Use Java 17 instanceof pattern matching in equals() method in Flink Core…

Open pranav234 opened this issue 7 months ago • 5 comments

… types

What is the purpose of the change

Refractor equals() method in different classes to use Java 17 pattern matching capabilities of Java 17 instance of operator

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): No
  • The serializers: (yes / no / don't know) No
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know) No
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know) No
  • The S3 file system connector: (yes / no / don't know) No

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) not applicable

pranav234 avatar May 13 '25 15:05 pranav234

CI report:

  • af8fa9ea8d5aec59ede47e342690ba934ec59775 Azure: FAILURE
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar May 13 '25 15:05 flinkbot

@flinkbot run azure

pranav234 avatar May 13 '25 15:05 pranav234

ping @rmetzger @davidradl

pranav234 avatar May 13 '25 15:05 pranav234

I wonder how it will work with jdk11 which is still used for nightly https://github.com/apache/flink/blob/4a77e9d959a4d78bd6075f7d7fe491b479cb4a69/tools/azure-pipelines/build-apache-repo.yml#L103-L110

snuyanzin avatar May 14 '25 07:05 snuyanzin

the CI FAILURE looks like a a checkstyle issue.

davidradl avatar May 15 '25 15:05 davidradl

This PR is being marked as stale since it has not had any activity in the last 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out to the community, contact details can be found here: https://flink.apache.org/what-is-flink/community/

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar Aug 14 '25 06:08 github-actions[bot]

This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open the PR and ask for a review.

github-actions[bot] avatar Sep 14 '25 06:09 github-actions[bot]