flink icon indicating copy to clipboard operation
flink copied to clipboard
verified publisher icon apache

[FLINK-37730][rest] Add client method for getting JM exception history

Open vsantwana opened this issue 7 months ago • 3 comments

What is the purpose of the change

(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)

This PR is a part of a bigger change in Flink Kubernetes Operator. As outline in this JIRA ticket, the idea is to expose the Job Manager Exceptions as Kubernetes Events.

This PR adds an API method to the RestClusterClient which will be then used in the operator's reconciler to keep a track of the exceptions.

Brief change log

(for example:)

  • The TaskInfo is stored in the blob store on job creation time as a persistent artifact

  • Deployments RPC transmits only the blob storage reference

  • TaskManagers retrieve the TaskInfo from the blob cache

  • RestClusterClient exposes method getJobExceptions given a JobID.

  • This is unit tested in RestClusterClientTest

Verifying this change

Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (100MB)
  • Extended integration test for recovery after master (JobManager) failure
  • Added test that validates that TaskInfo is transferred only once across recoveries
  • Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

vsantwana avatar May 02 '25 07:05 vsantwana

CI report:

  • a25b036f175747bcc3d5b3132c6bd66fd5d77b46 Azure: FAILURE
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar May 02 '25 07:05 flinkbot

@flinkbot run azure

vsantwana avatar May 02 '25 10:05 vsantwana

Thanks for the PR. Looks like CI is failing: https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=67465&view=logs&j=0da23115-68bb-5dcd-192c-bd4c8adebde1&t=24c3384f-1bcb-57b3-224f-51bf973bbee8&l=11740

rmetzger avatar May 06 '25 09:05 rmetzger