flink icon indicating copy to clipboard operation
flink copied to clipboard
verified publisher icon apache

[FLINK-36245][FOLLOWUP] Remove the @Deprecated for ArrowSourceFunction and SinkFunction

Open beliefer opened this issue 9 months ago • 6 comments

What is the purpose of the change

This PR follows up https://github.com/apache/flink/pull/25331 It seems missing the two classes.

Brief change log

Remove the @Deprecated for ArrowSourceFunction and SinkFunction

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

beliefer avatar Mar 14 '25 13:03 beliefer

CI report:

  • c3bcbdaa06b4bb7f6a9ca5167eb73a91fc1f5957 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Mar 14 '25 13:03 flinkbot

ping @lvyanquan @1996fanrui @davidradl cc @twalthr @JunRuiLee @afedulov

beliefer avatar Mar 14 '25 13:03 beliefer

@Poorvankbhatia After the rewrite, will the behavior changed? If yes, I think we should continue this deprecated pr.

beliefer avatar Mar 17 '25 06:03 beliefer

@Poorvankbhatia After the rewrite, will the behavior changed? If yes, I think we should continue this deprecated pr.

I think the core functionality of the source should remain the same, but the design is still WIP. So IMO we can keep the @deprecated annotation on ArrowSourceFunction

Poorvankbhatia avatar Mar 17 '25 09:03 Poorvankbhatia

IMO, I think this PR is not related to the rewrite work. This PR is just to fix bug that both deprecated with annotation and comment.

beliefer avatar Mar 17 '25 09:03 beliefer

This PR is being marked as stale since it has not had any activity in the last 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out to the community, contact details can be found here: https://flink.apache.org/what-is-flink/community/

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar Jun 19 '25 06:06 github-actions[bot]