flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-37357][table-planner]Migrating SqlNode conversion logic from SqlNodeToOperationConversion to SqlNodeConverters

Open Milesian111 opened this issue 9 months ago • 5 comments

[FLINK-37357][table-planner]Migrating SqlNode conversion logic from SqlNodeToOperationConversion to SqlNodeConverters

What is the purpose of the change

This pull request dealt with a "TODO" at class "SqlNodeToOperationConversion", method "convertValidatedSqlNode": "TODO: all the below conversion logic should be migrated to SqlNodeConverters". And I migrated over 40 of converters to SqlNodeConverters.

Brief change log

  • The Sql conversion logic codes in SqlNodeToOperationConversion are all migrated to SqlNodeConverters

Verifying this change

This change is already covered by existing tests, such as SqlDdlToOperationConverterTest and SqlDmlToOperationConverterTest .

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

Milesian111 avatar Feb 24 '25 11:02 Milesian111

CI report:

  • c9a0f26efb217a03278b91d9d25739188093401a Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Feb 24 '25 12:02 flinkbot

@flinkbot run azure

Milesian111 avatar Feb 25 '25 02:02 Milesian111

@flinkbot run azure

Milesian111 avatar Feb 25 '25 03:02 Milesian111

@schulzp @alpinegizmo @aljoscha @rmetzger @reswqa @mtfelisb @rmetzger Could anyone help review my code? Thank you very much!

Milesian111 avatar Mar 11 '25 03:03 Milesian111

This PR is being marked as stale since it has not had any activity in the last 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out to the community, contact details can be found here: https://flink.apache.org/what-is-flink/community/

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar Jun 09 '25 06:06 github-actions[bot]

This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open the PR and ask for a review.

github-actions[bot] avatar Jul 10 '25 06:07 github-actions[bot]