flink icon indicating copy to clipboard operation
flink copied to clipboard

FLINK-36505 remove deprecated methods TableFunction

Open jbalchan opened this issue 1 year ago • 2 comments

What is the purpose of the change

[FLINK-36505] https://issues.apache.org/jira/browse/FLINK-36505 Removed all deprecated methods - getResultType and getParameterTypes from TableFunction under table-common.

Brief change log

Removed all deprecated methods - getResultType and getParameterTypes from TableFunction under table-common.

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

jbalchan avatar Oct 16 '24 12:10 jbalchan

CI report:

  • c70715862e1c3ea0eca15648ad6b480fa7a044fc Azure: FAILURE
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Oct 16 '24 12:10 flinkbot

@flinkbot run azure

jbalchan avatar Oct 16 '24 13:10 jbalchan

I seem to find more references to the removed method getParameterTypes():

  • https://github.com/apache/flink/blob/master/flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/functions/utils/UserDefinedFunctionUtils.scala#L236
  • https://github.com/apache/flink/blob/master/flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/functions/utils/TableSqlFunction.scala#L138
  • https://github.com/apache/flink/blob/master/flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/TableFunctionCallGen.scala#L85

and some more for getResultType() as well.

tinaselenge avatar Oct 23 '24 13:10 tinaselenge

Hi, @jbalchan is there any progress on the ci failure?

xuyangzhong avatar Jan 02 '25 07:01 xuyangzhong

Re-Checking now. Will update by End of today.

jbalchan avatar Jan 02 '25 07:01 jbalchan

@flinkbot run azure

jbalchan avatar Jan 02 '25 15:01 jbalchan

@jbalchan the ci failed again where compiling, can you take a look again?

xuyangzhong avatar Jan 08 '25 11:01 xuyangzhong

This PR is being marked as stale since it has not had any activity in the last 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out to the community, contact details can be found here: https://flink.apache.org/what-is-flink/community/

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar Apr 09 '25 06:04 github-actions[bot]

This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open the PR and ask for a review.

github-actions[bot] avatar May 09 '25 06:05 github-actions[bot]