flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-36488] [TABLE SQL/API] Remove deprecated methods StreamTableEnvironment.toAppendStream from flink-table-api-java-bridge module

Open sn-12-3 opened this issue 1 year ago • 1 comments

JIRA issue

FLINK-36488

What is the purpose of the change

Remove deprecated method from StreamTableEnvironment.toAppendStream . This links to parent issue FLINK-36476

Brief change log

Remove deprecated methods StreamTableEnvironment.toAppendStream from flink-table-api-java-bridge module.

Verifying this change

Use mvn spotless:apply to verify.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

sn-12-3 avatar Oct 16 '24 05:10 sn-12-3

CI report:

  • ed785757c26983577c8bc430226982cb825d6b31 UNKNOWN
  • c5ed33e24a1c3ff60e2663f63b8eda3fe65e808a Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Oct 16 '24 05:10 flinkbot

@sn-12-3 do you mean to have this PR in draft ?

davidradl avatar Dec 05 '24 11:12 davidradl

Yes @davidradl , This PR CI is failing due to a python failure which still needs investigation.

sn-12-3 avatar Dec 05 '24 11:12 sn-12-3

Hi, @sn-12-3 Is there any new progress?

xuyangzhong avatar Jan 02 '25 05:01 xuyangzhong

@flinkbot run azure

sn-12-3 avatar Jan 13 '25 15:01 sn-12-3

Hi @xuyangzhong , This PR is ready for review now. I have removed the toAppendStream method from Scala and few tests which had references. Kindly let me know if any further changes is needed.

sn-12-3 avatar Jan 14 '25 04:01 sn-12-3

@flinkbot run azure

sn-12-3 avatar Jan 15 '25 08:01 sn-12-3

@flinkbot run azure

sn-12-3 avatar Jan 18 '25 11:01 sn-12-3

@xuyangzhong , @davidradl , Thanks for the review. Incorporated the review comments; PR is ready for re-review.

sn-12-3 avatar Jan 18 '25 17:01 sn-12-3

@xuyangzhong , @davidradl , Gentle reminder.

sn-12-3 avatar Jan 27 '25 14:01 sn-12-3

@flinkbot run azure

sn-12-3 avatar Feb 20 '25 17:02 sn-12-3

@xuyangzhong , @davidradl , Gentle reminder.

sn-12-3 avatar Mar 10 '25 10:03 sn-12-3