flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-36486] [TABLE SQL/API] Remove deprecated methods StreamTableEnvironment.registerDataStream from flink-table-api-java-bridge module

Open sn-12-3 opened this issue 1 year ago • 1 comments

JIRA issue

FLINK-36486

What is the purpose of the change

Remove deprecated method from StreamTableEnvironment.registerDataStream. This links to parent issue FLINK-36476

Brief change log

Remove deprecated methods StreamTableEnvironment.registerDataStream from flink-table-api-java-bridge module.

Verifying this change

Use mvn spotless:apply to verify.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

sn-12-3 avatar Oct 15 '24 18:10 sn-12-3

CI report:

  • 5e7d7b520a3c06b0867584fc9a48768cb4871cd5 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Oct 15 '24 18:10 flinkbot

@flinkbot run azure

sn-12-3 avatar Jan 07 '25 16:01 sn-12-3

@xuyangzhong , Thanks for the review. I have now removed the registerDataStream from the Scala StreamTableEnvironment. Could you please have a look at it.

sn-12-3 avatar Jan 08 '25 04:01 sn-12-3

LGTM, thanks for updating.

xuyangzhong avatar Jan 08 '25 10:01 xuyangzhong