flink icon indicating copy to clipboard operation
flink copied to clipboard

FLINK-36485 remove deprecated method fromDataStream

Open jbalchan opened this issue 1 year ago • 1 comments

What is the purpose of the change

https://issues.apache.org/jira/browse/FLINK-36485 Remove deprecated method StreamTableEnvironment fromDataStream

Brief change log

Removed deprecated method

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

jbalchan avatar Oct 15 '24 12:10 jbalchan

CI report:

  • c46b2a50eef0fc29eee193344f8a37d5027003cd Azure: FAILURE
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Oct 15 '24 12:10 flinkbot

Hi, @jbalchan can you take a look at the ci failure?

xuyangzhong avatar Jan 02 '25 03:01 xuyangzhong

@flinkbot run azure

jbalchan avatar Jan 02 '25 17:01 jbalchan

@jbalchan The ci failed when compiling, could you please resolve it again?

xuyangzhong avatar Jan 07 '25 07:01 xuyangzhong

@flinkbot run azure

jbalchan avatar Jan 09 '25 13:01 jbalchan

@flinkbot run azure

jbalchan avatar Jan 09 '25 14:01 jbalchan

@flinkbot run azure

xishuaidelin avatar Jan 13 '25 09:01 xishuaidelin

@jbalchan , @xishuaidelin it is impossible to make a compilation error resolved with rerunning the ci https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=65099&view=logs&j=b59e5554-36c7-5512-ab1a-b80b74075fce&t=849d419c-1b8f-52b7-e455-d4bc36ec43ad&l=7894

as it is mentioned in logs

09:53:18.506 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) on project flink-table-api-java-bridge: Compilation failure
09:53:18.506 [ERROR] /__w/3/s/flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/api/bridge/java/internal/StreamTableEnvironmentImpl.java:[308,5] method does not override or implement a method from a supertype
09:53:18.506 [ERROR] 

the code should be adapted to be compilable and to pass tests

snuyanzin avatar Jan 14 '25 22:01 snuyanzin

This PR is being marked as stale since it has not had any activity in the last 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out to the community, contact details can be found here: https://flink.apache.org/what-is-flink/community/

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar Apr 16 '25 06:04 github-actions[bot]

This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open the PR and ask for a review.

github-actions[bot] avatar May 17 '25 06:05 github-actions[bot]