flink icon indicating copy to clipboard operation
flink copied to clipboard

FLINK-36481 Remove deprecated method TableDescriptor forManaged

Open jbalchan opened this issue 1 year ago • 1 comments

What is the purpose of the change

https://issues.apache.org/jira/browse/FLINK-36481 Remove deprecated methods TableDescriptor.forManaged

Brief change log

Remove deprecated methods

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

jbalchan avatar Oct 15 '24 11:10 jbalchan

CI report:

  • 113165297869d1b55df2a1008dd6bdc1cc653bcc Azure: FAILURE
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Oct 15 '24 11:10 flinkbot

Hi, @jbalchan can you take a look at the ci failure?

xuyangzhong avatar Jan 02 '25 03:01 xuyangzhong

@jbalchan You only removed the method TableDescriptor#forManaged without adapting all the code that uses that method.

xuyangzhong avatar Jan 07 '25 11:01 xuyangzhong

Since the removal work for managed table is too big, I have created a new pr https://github.com/apache/flink/pull/25910 for that and add you as a co-author there.

xuyangzhong avatar Jan 08 '25 09:01 xuyangzhong

Thankyou @xuyangzhong. Closing this PR since this is no longer useful.

jbalchan avatar Jan 16 '25 08:01 jbalchan