flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-36066][runtime] Introducing the AdaptiveGraphManager component

Open noorall opened this issue 1 year ago • 3 comments

What is the purpose of the change

To support the incremental generation of JobGraph and update the StreamGraph based on runtime information, we plan to introduce the AdaptiveGraphManager component, which will implement the AdaptiveGraphGenerator interface. The AdaptiveGraphGenerator interface is responsible for:

  1. Generating the JobGraph
  2. Responding to upstream job vertex finished events, generating JobVertex, and updating it to the JobGraph
  3. Providing StreamGraphContext to allow StreamGraphOptimizer to add, delete, and modify StreamNode and StreamEdge

Brief change log

  • Implement the AdaptiveGraphGenerator interface
  • Implement the StreamGraphContext interface
  • Some UT cases

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

noorall avatar Sep 27 '24 03:09 noorall

@flinkbot run azure

noorall avatar Sep 27 '24 03:09 noorall

CI report:

  • 8dce314977a27765727a468987f96f83fcd41caf UNKNOWN
  • bb315a49b46c8a9c56056a2f989fc6172fc4ad73 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Sep 27 '24 04:09 flinkbot

@flinkbot run azure

noorall avatar Oct 17 '24 01:10 noorall

Thank @noorall for the update. Such a complex refactoring is no easy task. I've left some comments, please take a look

Thanks for your review. The PR has been updated according to your comments.

noorall avatar Nov 15 '24 05:11 noorall

Thanks for addressing all the comments above. @noorall I have a few comments regarding the first 2 commits.

Thanks for your review. The PR has been updated according to your comments.

noorall avatar Nov 26 '24 06:11 noorall