flink icon indicating copy to clipboard operation
flink copied to clipboard

Detect base href dynamically

Open abhijitWakchaure opened this issue 1 year ago • 1 comments

What is the purpose of the change

This pull request makes flink-runtime-web project detect the base href dynamically so that it can work with paths like http://foo.bar/my-flink-dashboard

Brief change log

  • Dynamically insert the <base href="" /> tag based on the current path instead of hard coded <base href="/" />
  • Added provider for APP_BASE_HREF which points to window.location.pathname

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

abhijitWakchaure avatar Sep 26 '24 15:09 abhijitWakchaure

CI report:

  • 24851cffc7e7574f14eba66e56665f2373a82dac Azure: FAILURE
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Sep 26 '24 16:09 flinkbot

This PR is being marked as stale since it has not had any activity in the last 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out to the community, contact details can be found here: https://flink.apache.org/what-is-flink/community/

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar Apr 07 '25 06:04 github-actions[bot]

This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open the PR and ask for a review.

github-actions[bot] avatar May 08 '25 06:05 github-actions[bot]