flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-33045][format avro-confluent] disable auto-registering schema in registry

Open parisni opened this issue 1 year ago • 9 comments

What is the purpose of the change

plz cf jira

Brief change log

  • added support for standard way to enable/disable auto-registering schema in the registry
  • default to auto-registering (current behavior)
  • allow both datastream / table API
  • confirmed the datastream API works fine on our pipeline

Verifying this change

Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (100MB)
  • Extended integration test for recovery after master (JobManager) failure
  • Added test that validates that TaskInfo is transferred only once across recoveries
  • Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

parisni avatar Sep 26 '24 15:09 parisni

CI report:

  • 1be9cea5732424663a93c2099af20621e92ca19c Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Sep 26 '24 16:09 flinkbot

Hi! Still seeing this open, do we want to merge the change? It would be helpful if we can enable this

xyz5881 avatar Jan 15 '25 19:01 xyz5881

Thanks for the interest. I think so.

parisni avatar Jan 15 '25 20:01 parisni

Hey thanks for working on this - just checking in if we can merge this soon? This bug is causing very annoying bugs on our side and I think others are facing the same issue.

albert597 avatar Mar 05 '25 06:03 albert597

Would also be super grateful if this can be merged soon, we're facing the same issues.

buenzlidominik avatar Mar 21 '25 11:03 buenzlidominik

@buenzlidominik likely nobody from the maintainer did take a look at this

parisni avatar Mar 25 '25 08:03 parisni

This is such a fundamental requirement for users who pre-register schemas or use data contracts to define Avro classes outside of applications.

HenkvanDyk avatar Jun 02 '25 12:06 HenkvanDyk

Agreed. Plz contact maintainers if you wan't this merged.

parisni avatar Jun 02 '25 13:06 parisni

+1 This is stopping us from using avro-confluent

rob-dempsey-iag avatar Jun 05 '25 09:06 rob-dempsey-iag

This PR is being marked as stale since it has not had any activity in the last 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out to the community, contact details can be found here: https://flink.apache.org/what-is-flink/community/

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar Sep 18 '25 06:09 github-actions[bot]

This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open the PR and ask for a review.

github-actions[bot] avatar Oct 19 '25 06:10 github-actions[bot]