flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-36277][table] Remove all direct uses of `TableEnvironmentInternal#registerTableSourceInternal` in table module

Open xuyangzhong opened this issue 1 year ago • 1 comments

What is the purpose of the change

Remove all direct uses of TableEnvironmentInternal#registerTableSourceInternal in table module.

Brief change log

  • Remove all blocking subclasses of TableSource related to the removal of TableEnvironmentInternal#registerTableSourceInternal, except TestTableSource in tests
  • Create a DynamicTableSource instead of registering a legacy TableSource in tests

Verifying this change

This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented?

xuyangzhong avatar Sep 13 '24 11:09 xuyangzhong

CI report:

  • 8313ce496cd5487250ea94ba8974f76ffb6ffb6d Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Sep 13 '24 11:09 flinkbot

Hey @xuyangzhong , @lsyldliu It seems this is the reason of master failure https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=64822&view=logs&j=0c940707-2659-5648-cbe6-a1ad63045f0a&t=075c2716-8010-5565-fe08-3c4bb45824a4&l=12021

since between PR was submitted and the datetime it was merged there was added AdaptiveJoin (https://github.com/apache/flink/pull/25578)

I submitted a fix for that, could you please have a look?

https://github.com/apache/flink/pull/25895

snuyanzin avatar Jan 03 '25 23:01 snuyanzin