flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-36266][table] Insert into as select * behaves incorrect

Open snuyanzin opened this issue 1 year ago • 2 comments

What is the purpose of the change

The PR fixes behavior for insert into queries with select * like

INSERT INTO t(f0, f1 ,f2) SELECT * FROM t1;

Verifying this change

FlinkCalciteSqlValidatorTest.java

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: ( no)
  • The runtime per-record code paths (performance sensitive): ( no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: ( no)
  • The S3 file system connector: ( no)

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (not applicable )

snuyanzin avatar Sep 11 '24 23:09 snuyanzin

CI report:

  • 06378c46e2c717da99671a380dee6cb117206b10 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Sep 11 '24 23:09 flinkbot

@flinkbot run azure

snuyanzin avatar Oct 11 '24 14:10 snuyanzin

@flinkbot run azure

snuyanzin avatar Oct 25 '24 18:10 snuyanzin

@flinkbot run azure

snuyanzin avatar Oct 25 '24 19:10 snuyanzin

@flinkbot run azure

snuyanzin avatar Oct 26 '24 20:10 snuyanzin

@flinkbot run azure

snuyanzin avatar Oct 27 '24 05:10 snuyanzin

Would it make sense to add a test case to something like TableSinkITCase to validate things end-to-end and also prevent regressions?

jnh5y avatar Nov 05 '24 16:11 jnh5y