flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time

Open XComp opened this issue 1 year ago • 2 comments

What is the purpose of the change

Removes deprecated org.apache.flink.streaming.api.windowing.time.Time

Brief change log

The changes where done using the IDE refactoring and find&replace operations.

Verifying this change

  • CI should pass

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

XComp avatar Aug 28 '24 18:08 XComp

CI report:

  • 78698ef0b523d9da3d3b3dc64656ba990c809470 Azure: PENDING
  • 0000 Unknown: CANCELED
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Aug 28 '24 18:08 flinkbot

Converting this one to draft. Things to do: :heavy_check_mark: Going through the code diff and identifying wrong/missing code changes :heavy_check_mark: Going through the docs diff and identifying wrong/missing changes

XComp avatar Aug 29 '24 05:08 XComp

Most of the Scala code is gone in master now which unblocked this PR (I had an issue with the Scala compiler fixing one of the windowAll comments and I didn't want to bother to fix it considering that we were planning to remove the Scala code). I rebased the branch and addressed all comments.

XComp avatar Sep 27 '24 07:09 XComp

Failure related to FLINK-36356.

XComp avatar Sep 27 '24 11:09 XComp

@flinkbot run azure

XComp avatar Sep 27 '24 11:09 XComp

Bit irritated that we still got scala examples in the docs, but it's not a problem for this PR I suppose.

Looks like there is a separate issue FLINK-36352 for that.

XComp avatar Sep 27 '24 14:09 XComp

@flinkbot run azure

XComp avatar Sep 27 '24 14:09 XComp

@flinkbot run azure

XComp avatar Sep 28 '24 15:09 XComp

Something's odd with the cibot. But GHA had a successful CI run on this PR/commit: https://github.com/XComp/flink/actions/runs/11091729815

I will merge the PR. Thanks for the approval

XComp avatar Sep 29 '24 14:09 XComp