flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-36125] Fix concurrent duplicate discard of logical file in cp file-merging

Open Zakelly opened this issue 1 year ago • 1 comments

What is the purpose of the change

There might be a duplicate discard of logical file in cp file-merging when cp abortion + io exception + two threads happen to release the file at the same time.

Brief change log

  • Make the LogicalFile can only be discarded once.

Verifying this change

It is not easy to verify this, since it is a rare concurrent issue.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

Zakelly avatar Aug 22 '24 12:08 Zakelly

CI report:

  • 06b40412fcb7cc1f3ed90808fddedb68a3404649 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Aug 22 '24 12:08 flinkbot