flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-36029] Add @Nullable Annotation to ValueState's Value Method Return Type

Open twosom opened this issue 1 year ago • 1 comments

What is the purpose of the change

The ValueState#value description says that null can be returned, but the method does not have the @Nullable annotation.

So it seems reasonable to add the @Nullable annotation to make it easier for the IDE to find the NPE.

Brief change log

  • added @javax.annotation.Nullable annotation on ValueState#value

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

twosom avatar Aug 11 '24 05:08 twosom

CI report:

  • 19786a68eb6d75889eeec395cf6aae6cd040c293 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Aug 11 '24 05:08 flinkbot

This PR is being marked as stale since it has not had any activity in the last 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out to the community, contact details can be found here: https://flink.apache.org/what-is-flink/community/

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar Apr 06 '25 06:04 github-actions[bot]

This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open the PR and ask for a review.

github-actions[bot] avatar May 07 '25 06:05 github-actions[bot]