flink icon indicating copy to clipboard operation
flink copied to clipboard

[hotfix][runtime] Optimize the naming of the slotPool attribute in DefaultDeclarativeSlotPool

Open RocMarshal opened this issue 1 year ago • 1 comments

What is the purpose of the change

Optimize the naming of the slotPool attribute in DefaultDeclarativeSlotPool.

  • DeclarativeSlotPool
  • SlotPool
  • SlotPoolService These three are interface classes.It's a bit confusing to use the name of the slotPool(The type of it is AllocatedSlotPool) variable naming in the implementation of DeclarativeSlotPool.

Brief change log

Optimize the naming of the slotPool attribute in DefaultDeclarativeSlotPool renaming slotPool to allocatedSlotPool.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

RocMarshal avatar Jul 30 '24 07:07 RocMarshal

CI report:

  • a46a1ba1ad3a41994cf71eb78664095bd2f58a85 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Jul 30 '24 08:07 flinkbot