flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-35566] Promote TypeSerializer from PublicEvolving to Public

Open superdiaodiao opened this issue 1 year ago • 4 comments

What is the purpose of the change

Promote TypeSerializer from PublicEvolving to Public

Brief change log

Promote TypeSerializer interfaces

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

superdiaodiao avatar Jul 12 '24 14:07 superdiaodiao

CI report:

  • cbe41a237c707d35fd541dca3987cf8f95372a7d Azure: FAILURE
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Jul 12 '24 15:07 flinkbot

Thanks for the PR. If we want to also upgrade TypeSerializerSnapshot to Public, it's better to do this after removing related deprecated methods in 2.0.

So in this PR, it's better not to touch TypeSerializerSnapshot, right?

BTW, what about TypeSerializerSchemaCompatibility?

superdiaodiao avatar Jul 17 '24 06:07 superdiaodiao

Thanks for the PR. If we want to also upgrade TypeSerializerSnapshot to Public, it's better to do this after removing related deprecated methods in 2.0.

So in this PR, it's better not to touch TypeSerializerSnapshot, right?

BTW, what about TypeSerializerSchemaCompatibility?

IMO, It's better to promote these classes together since users usually use them together. So maybe let's remove related deprecated methods firstly. @JingGe WDYT?

masteryhx avatar Jul 19 '24 07:07 masteryhx

IMO, It's better to promote these classes together since users usually use them together. So maybe let's remove related deprecated methods firstly. @JingGe WDYT?

@JingGe May I ask what is your opinion?

superdiaodiao avatar Sep 29 '24 08:09 superdiaodiao

IMO, It's better to promote these classes together since users usually use them together. So maybe let's remove related deprecated methods firstly. @JingGe WDYT?

@JingGe May I ask what is your opinion?

Related deprecated methods have been removed in https://github.com/apache/flink/pull/25384 I think we could go ahead.

masteryhx avatar Oct 22 '24 10:10 masteryhx

This PR is being marked as stale since it has not had any activity in the last 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out to the community, contact details can be found here: https://flink.apache.org/what-is-flink/community/

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar Apr 12 '25 06:04 github-actions[bot]

This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open the PR and ask for a review.

github-actions[bot] avatar May 13 '25 06:05 github-actions[bot]