flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-35731][runtime] Fix incorrect parallelism configured detection for Sink V2.

Open JunRuiLee opened this issue 1 year ago • 1 comments

What is the purpose of the change

Fix incorrect parallelism configured detection for Sink V2.

Brief change log

  • Fix incorrect parallelism configured detection for Sink V2.
  • Set job vertex parallelism in advance when forward group parallelism is decided to ensure CommittableSummary and CommittableWithLineage order.

Verifying this change

This change can be verified by StreamingJobGraphGeneratorTest#testParallelismConfiguredForSinkV2 and SinkITCase.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

JunRuiLee avatar Jun 30 '24 10:06 JunRuiLee

CI report:

  • 5355f30c1f353d55e8e6ac331ca030cccb8edd17 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Jun 30 '24 10:06 flinkbot

@fapaul Thanks for the review! I've already addressed the comments and updated the PR. PTAL. And @Zhuzhu, could you please review the changes, especially for adaptive batch scheduler?

JunRuiLee avatar Jul 02 '24 06:07 JunRuiLee

Squashed the commits and rebased onto master.

JunRuiLee avatar Jul 02 '24 13:07 JunRuiLee