flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-25537] [JUnit5 Migration] Module: flink-core

Open GOODBOY008 opened this issue 1 year ago • 2 comments

The left in core module.

GOODBOY008 avatar Jun 14 '24 10:06 GOODBOY008

CI report:

  • 04110163f802c6d688142b0611f33d488ac03abd Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Jun 14 '24 10:06 flinkbot

@1996fanrui @Jiabao-Sun The last pr of core module. PTAL

GOODBOY008 avatar Jun 14 '24 14:06 GOODBOY008

#24945 reverts the InitOutputPathTest to junit4.

We can research why InitOutputPathTest fails after migrating juint5, and fix it later in this PR as well.

@1996fanrui The class failed because of the jdk verison, and I fixed in this pr.

GOODBOY008 avatar Jul 12 '24 02:07 GOODBOY008

@GOODBOY008 This change makes JDK21 unhappy. see FLINK-35837. Would you mind taking a look?

cc @1996fanrui @Jiabao-Sun

reswqa avatar Jul 16 '24 03:07 reswqa

@GOODBOY008 This change makes JDK21 unhappy. see FLINK-35837. Would you mind taking a look?

cc @1996fanrui @Jiabao-Sun

@reswqa I will take a look.

GOODBOY008 avatar Jul 16 '24 03:07 GOODBOY008