flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-35598][sql-parser] Fix error comparison type ExtendedSqlRowTypeNameSpec#equalsDeep

Open wzx140 opened this issue 1 year ago • 4 comments

Brief change log

Fix error comparison type ExtendedSqlRowTypeNameSpec#equalsDeep.

ExtendedSqlRowTypeNameSpec nameSpec = new ExtendedSqlRowTypeNameSpec(
        SqlParserPos.ZERO,
        Arrays.asList(
                new SqlIdentifier("column1", SqlParserPos.ZERO),
                new SqlIdentifier("column2", SqlParserPos.ZERO)),
        Arrays.asList(
                new SqlDataTypeSpec(new SqlBasicTypeNameSpec(
                        SqlTypeName.INTEGER,
                        SqlParserPos.ZERO), SqlParserPos.ZERO),
                new SqlDataTypeSpec(new SqlBasicTypeNameSpec(
                        SqlTypeName.INTEGER,
                        SqlParserPos.ZERO), SqlParserPos.ZERO)),
        Collections.emptyList(), true
);
// Throw exception
nameSpec.equalsDeep(nameSpec, Litmus.THROW);

wzx140 avatar Jun 14 '24 04:06 wzx140

CI report:

  • 9ded30065f716b0fb6df370cfcc45d9f12a2ae15 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Jun 14 '24 04:06 flinkbot

@1996fanrui Could you please review it? Really thanks!

wzx140 avatar Jun 14 '24 04:06 wzx140

Could you please review it? Really thanks!

Sorry, I'm not familiar with sql or table module, I'm unable to review this PR.

Thank you for your response! I understand. I'll find someone else who is more familiar with SQL module to review this PR.

wzx140 avatar Jun 14 '24 12:06 wzx140

@dawidwys Could you please review it?

wzx140 avatar Jun 14 '24 12:06 wzx140

This PR is being marked as stale since it has not had any activity in the last 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out to the community, contact details can be found here: https://flink.apache.org/what-is-flink/community/

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar Apr 06 '25 06:04 github-actions[bot]

This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open the PR and ask for a review.

github-actions[bot] avatar May 06 '25 06:05 github-actions[bot]