flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-35595][core] MailboxProcessor#processMailsWhenDefaultActionUnavailable avoids allocating Optional

Open schlosna opened this issue 1 year ago • 1 comments

What is the purpose of the change

Reduce allocations and garbage collection overhead due to Optionals on hot path from org.apache.flink.streaming.runtime.tasks.mailbox.MailboxProcessor#runMailboxLoop.

Brief change log

  • Remove unnecessary allocation of Optionals in org.apache.flink.streaming.runtime.tasks.mailbox. MailboxProcessor#processMailsWhenDefaultActionUnavailable() method

Verifying this change

This change is already covered by existing tests org.apache.flink.streaming.runtime.tasks.mailbox.TaskMailboxProcessorTest.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): not per record, but mailbox is performance sensitive
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

schlosna avatar Jun 12 '24 04:06 schlosna

CI report:

  • 25259468debfa0c4bd11f9bfdac0f638e094ec0e Azure: CANCELED
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Jun 12 '24 04:06 flinkbot

This PR is being marked as stale since it has not had any activity in the last 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out to the community, contact details can be found here: https://flink.apache.org/what-is-flink/community/

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar Apr 06 '25 06:04 github-actions[bot]

@flinkbot run azure

schlosna avatar Apr 26 '25 18:04 schlosna

This PR is being marked as stale since it has not had any activity in the last 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out to the community, contact details can be found here: https://flink.apache.org/what-is-flink/community/

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar Jul 28 '25 06:07 github-actions[bot]

This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open the PR and ask for a review.

github-actions[bot] avatar Aug 28 '25 06:08 github-actions[bot]