flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-34673][test] Fix SessionRelatedITCase#testTouchSession failure on GitHub Actions

Open juanvisoler opened this issue 1 year ago • 5 comments

What is the purpose of the change

Fixes flaky test SessionRelatedITCase#testTouchSession by sending the touch request 1ms later.

Brief change log

Fixes flaky test SessionRelatedITCase#testTouchSession.

juanvisoler avatar May 22 '24 10:05 juanvisoler

CI report:

  • 369051e174725576bfdfb735165127ce7e4c031f Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar May 22 '24 10:05 flinkbot

@RyanSkraba should we merge this?

juanvisoler avatar Feb 16 '25 19:02 juanvisoler

This PR is being marked as stale since it has not had any activity in the last 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out to the community, contact details can be found here: https://flink.apache.org/what-is-flink/community/

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar May 18 '25 06:05 github-actions[bot]

It should be merged, yes! I'm not a committer :smile: If I remember correctly, I reran the test in my IDE continuously until failure. It always ended up failing eventually before the fix and "never" ended up failing after the fix (well, for as long as I ran it).

RyanSkraba avatar Jun 04 '25 16:06 RyanSkraba

Maybe @fsk119 or @xintongsong might be interested in reviewing (or closing if it's no longer relevant)?

RyanSkraba avatar Jun 04 '25 16:06 RyanSkraba