flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-35318][table-planner] use UTC timezone to handle TIMESTAMP_WITHOUT_TIME_ZONE type in RexNodeToExpressionConverter

Open lshangq opened this issue 1 year ago • 5 comments

RexNodeToExpressionConverter#visitLiteral should not convert the literal to UTC using specified timezone again since this has been done before at the SQL to Rel phase.

lshangq avatar May 15 '24 02:05 lshangq

CI report:

  • cfca7a75c31271f465b27900f4d7b5740e7e6968 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar May 15 '24 02:05 flinkbot

Hi, @LadyForest. Do you plan to continue reviewing it? If you're busy, I'd be happy to continue the review.

xuyangzhong avatar Jun 21 '24 06:06 xuyangzhong

Hi, @LadyForest. Do you plan to continue reviewing it? If you're busy, I'd be happy to continue the review.

Free feel to go ahead.

LadyForest avatar Jun 21 '24 06:06 LadyForest

Thanks for the contribution. The PR looks good to me in general, and I only left one minor comment.

@LadyForest Thanks for your review. I have made the revisions based on your comments. Please take a look when you have time.

lshangq avatar Jun 25 '24 02:06 lshangq

@leonardBang could you help check this? Because there was a previous related time behavior revisit and change(FLIP-162).

lincoln-lil avatar Jun 25 '24 06:06 lincoln-lil

@leonardBang Could you help to take a look at it. Or how do you think it should be changed?

lshangq avatar Jul 03 '24 02:07 lshangq

@lshangq Would you like to also open PRs for release-1.19 and release-1.20 branch?

leonardBang avatar Jul 15 '24 06:07 leonardBang

@lshangq Would you like to also open PRs for release-1.19 and release-1.20 branch?

@leonardBang Thanks for merging. Of course.

lshangq avatar Jul 16 '24 07:07 lshangq

@leonardBang Could you please take a look when you have time? cherry-pick to release-1.19 https://github.com/apache/flink/pull/25093

cherry-pick to release-1.20 https://github.com/apache/flink/pull/25094

lshangq avatar Jul 22 '24 07:07 lshangq