flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-35351][checkpoint] Fix fail during restore from unaligned chec…

Open ldadima opened this issue 9 months ago • 1 comments

What is the purpose of the change

To fix FLINK-35351

Verifying this change

UnalignedCheckpointCustomRescaleITCase#restoreFromCheckpoint

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (not applicable)

ldadima avatar May 14 '24 09:05 ldadima

CI report:

  • b4b928efdd6def04440f10b388d73d9d7c91db75 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar May 14 '24 09:05 flinkbot

Also please note that azure is failing on some compilation issue. Probably some check style violation.

pnowojski avatar May 17 '24 08:05 pnowojski

Sorry to bother you again, but I made a separate one Pull request with hotfix

ldadima avatar May 20 '24 18:05 ldadima

Thanks for the update @ldadima . I have fixed up a couple of things in https://github.com/apache/flink/pull/24857 so let me close this PR in favour of that one. Could you take a look at my version?

pnowojski avatar May 28 '24 16:05 pnowojski

Thanks for the update @ldadima . I have fixed up a couple of things in #24857 so let me close this PR in favour of that one. Could you take a look at my version?

I checked the MR. I agree with changes about ITCase. In my case I forget about uid, that's why map vertex doesn't work for me in rescale case. Thanks for changes

ldadima avatar May 29 '24 04:05 ldadima