flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-35047][state] Shutdown StateExecutors when ForStKeyedStateBackend is disposed

Open ljz2051 opened this issue 1 year ago • 1 comments

What is the purpose of the change

This pull request shuts down the ForStStateExecutors when ForStKeyedStateBackend is disposed.

Brief change log

  • Shutdown the StateExecutors in ForStKeyedStateBackend.

Verifying this change

This change is already covered by existing tests, such as ForStStateBackendConfigTest and AsyncExecutionControllerTest.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

ljz2051 avatar May 10 '24 05:05 ljz2051

CI report:

  • 1f9e43a60666364085c0567b2a5cdc4e260f4e3e Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar May 10 '24 05:05 flinkbot

I think we'd better note the shutdown contract down into the description/Javadoc of StateExecutor. The StateExecutor is managed by KeyedStateBackend and the AEC or operators won't take care of the lifecycle of it.

@Zakelly Thanks for your suggestion. I have refined the JavaDoc in AsyncKeyedStateBackend#createStateExecutor and StateExecutor.

ljz2051 avatar May 17 '24 06:05 ljz2051