flink icon indicating copy to clipboard operation
flink copied to clipboard
verified publisher icon apache

[FLINK-35240][Connectors][format]Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record for csv format

Open GOODBOY008 opened this issue 1 year ago • 4 comments

Changes:

  • Disable FLUSH_AFTER_WRITE_VALUE
  • Use ObjectWriter#writeValue(org.apache.flink.shaded.jackson2.com.fasterxml.jackson.core.JsonGenerator, java.lang.Object) instead of ObjectWriter#writeValue(java.io.OutputStream, java.lang.Object)
  • Manual flush JsonGenerator

GOODBOY008 avatar Apr 26 '24 16:04 GOODBOY008

CI report:

  • 4d835f9272304bd5535f1d0ac96261e8e92eece9 Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Apr 26 '24 16:04 flinkbot

@robobario Thanks for your kind suggestions. PR is updated, PTAL~

GOODBOY008 avatar Apr 29 '24 05:04 GOODBOY008

@afedulov @robobario I had added unit test for this. Thank you @afedulov for giving draft it unit test to me.

GOODBOY008 avatar May 28 '24 07:05 GOODBOY008

@leonardBang PTAL

GOODBOY008 avatar Jun 20 '24 11:06 GOODBOY008

CI Passed Merging.

GOODBOY008 avatar Jul 11 '24 12:07 GOODBOY008