flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-34618][table] Migrate SplitPythonConditionFromJoinRule to java.

Open damumu0625 opened this issue 1 year ago • 2 comments

What is the purpose of the change

The PR migrates SplitPythonConditionFromJoinRule to java it doesn't touch SplitPythonConditionFromJoinRuleTest to be sure that java version continues passing it

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

damumu0625 avatar Mar 12 '24 09:03 damumu0625

CI report:

  • 6dccd02cff59d45c35c69576812b240ae21748b3 Azure: FAILURE
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Mar 12 '24 09:03 flinkbot

LGTM, only left a minor comment

liuyongvs avatar Mar 13 '24 02:03 liuyongvs