flink icon indicating copy to clipboard operation
flink copied to clipboard

[FLINK-34600][table] Migrate PushLimitIntoLegacyTableSourceScanRule to java

Open snuyanzin opened this issue 1 year ago • 1 comments

What is the purpose of the change

A bit reasoning for the change

The reason is that since 1.28.0 ( CALCITE-4787 - Move core to use Immutables instead of ImmutableBeans ) Calcite started to use Immutables (https://immutables.github.io/) and since 1.29.0 removed ImmutableBeans ( CALCITE-4839 - Remove remnants of ImmutableBeans post 1.28 release ). All rule configuration related api which is not Immutables based is marked as deprecated. Since Immutables implies code generation while java compilation it is seems impossible to use for rules in Scala code.

The PR migrates PushLimitIntoLegacyTableSourceScanRule to java it doesn't touch PushLimitIntoLegacyTableSourceScanRuleTest to be sure that java version continues passing it

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: (no )
  • The runtime per-record code paths (performance sensitive): (no )
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no )

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

snuyanzin avatar Mar 06 '24 23:03 snuyanzin

CI report:

  • c7677e3696d46b6d5ae5b86eeec8fb365ab6bf3f Azure: SUCCESS
Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

flinkbot avatar Mar 06 '24 23:03 flinkbot